0000150: How can we differentiate the signals from PUT or GET requesst?

(0000515)
skirsdeda (администратор)
2008-12-01 11:37

I could put this info in transfer info, then you would have to call GetTransferInfo after getting TransferStarted signal.

(0000516)
Jo (инициатор)
2008-12-01 11:49

That's a good idea. I will test it immediately if the code is available.

(0000529)
Jo (инициатор)
2009-02-06 13:03

Hi, Tadas,
How do you think about the following patch in ods_obex_transfer_get_info function, ods-obex.c? As you said we can distinguish the obex command type after receiving TS signal using GetTransferInfo dbus call.

--
    if (obex_context->obex_cmd==OBEX_CMD_GET)
        g_hash_table_insert (info, "OBEXCommand", g_strdup("GET"));
    else if (obex_context->obex_cmd==OBEX_CMD_PUT)
        g_hash_table_insert (info, "OBEXCommand", g_strdup("PUT"));
    else
        g_hash_table_insert (info, "OBEXCommand", g_strdup("Not Available"));

(0000530)
skirsdeda (администратор)
2009-02-06 14:20

Yes, this is perfectly fine. I just forgot about this bug.. I'll submit a fix soonish :)

(0000536)
skirsdeda (администратор)
2009-02-06 23:29

Fixed in svn rev 2529 (ditched the "NotAvailable" (just doesn't add OBEXCommand if it's neither PUT nor GET)

история
Дата изменения	Пользователь	Поле	Изменение
2008-12-01 07:35	Jo	Новый вопрос
2008-12-01 11:37	skirsdeda	Комментарий добавлен: 0000515
2008-12-01 11:49	Jo	Комментарий добавлен: 0000516
2009-02-06 13:03	Jo	Комментарий добавлен: 0000529
2009-02-06 14:20	skirsdeda	Комментарий добавлен: 0000530
2009-02-06 14:20	skirsdeda	Состояние	новый => назначен
2009-02-06 14:20	skirsdeda	Ответственный	=> skirsdeda
2009-02-06 23:29	skirsdeda	Комментарий добавлен: 0000536
2009-02-06 23:29	skirsdeda	Состояние	назначен => отработан
2009-02-06 23:29	skirsdeda	Решение	открыт => решен
2009-02-06 23:30	skirsdeda	Решен в версии	=> 0.4.3
2009-02-08 17:25	skirsdeda	Состояние	отработан => закрыт

Комментарии
(0000515) skirsdeda (администратор) 2008-12-01 11:37	I could put this info in transfer info, then you would have to call GetTransferInfo after getting TransferStarted signal.

(0000516) Jo (инициатор) 2008-12-01 11:49	That's a good idea. I will test it immediately if the code is available.

(0000529) Jo (инициатор) 2009-02-06 13:03	Hi, Tadas, How do you think about the following patch in ods_obex_transfer_get_info function, ods-obex.c? As you said we can distinguish the obex command type after receiving TS signal using GetTransferInfo dbus call. -- if (obex_context->obex_cmd==OBEX_CMD_GET) g_hash_table_insert (info, "OBEXCommand", g_strdup("GET")); else if (obex_context->obex_cmd==OBEX_CMD_PUT) g_hash_table_insert (info, "OBEXCommand", g_strdup("PUT")); else g_hash_table_insert (info, "OBEXCommand", g_strdup("Not Available"));

(0000530) skirsdeda (администратор) 2009-02-06 14:20	Yes, this is perfectly fine. I just forgot about this bug.. I'll submit a fix soonish :)

(0000536) skirsdeda (администратор) 2009-02-06 23:29	Fixed in svn rev 2529 (ditched the "NotAvailable" (just doesn't add OBEXCommand if it's neither PUT nor GET)

Связи