Mantis Bugtracker

Простой вид комментарии ] расширенный вид ] история ] печать ]
Номер Категория Серьезность Воспроизводимость Создан Изменен
0000073 [obex-data-server] General большая неприменима 2008-05-09 17:07 2008-10-17 19:59
Инициатор cktakahasi Видимость общая  
Ответственный skirsdeda
Приоритет обычный Решение решен  
Состояние закрыт   Версия продукта 0.3.1
Суть 0000073: Use BlueZ 4.0 API
Подробности BlueZ D-Bus API 3.X are going to be deprecated. ODS needs to be converted to the new API.
Дополнительные сведения
Tэги Нет прикрепленных тэгов.
Вложенные файлы ? file icon new_api.patch [^] (1,237 bytes) 2008-07-02 18:17
? file icon ods_bluez4_api.patch [^] (1,990 bytes) 2008-07-06 01:23

- Связи
блокирует 0000058закрытskirsdeda 0.4 tracker 

-  Комментарии
(0000232)
heston_james (инициатор)
2008-05-12 15:48

This is definitily something which needs to be looked at, I wonder when though. Do we have any idea when a stable release of BlueZ using this new API is due for public release? I dont think we need worry untill then.

At the moment I use the old API for other applications and wouldnt be upgrading my distribution untill I could be sure it was stable.

Heston.
(0000325)
skirsdeda (администратор)
2008-06-28 21:17

I am gonna do a compile-time option for bluez 4.x API.
(0000327)
heston_james (инициатор)
2008-06-29 12:57

Thats a very nice idea Skirs I appreciate that it'll make life a little trickier from a code standpoint, but for the moment I think a large majority will still likely use whatever version of bluez is in the stable apt repositoties.

Good man,

Heston
(0000337)
manuel (инициатор)
2008-07-02 18:17

This patch works the same way bluez does.

In bluez to enable the 4.0 API you need to tell hcid to use it by passing -x to it.

Well this patch does exactly the same, and shares a function to all the rest of the code that lets it know which API should be used.

Thanks,
Manuel Naranjo
manuel at aircable dot net
(0000351)
skirsdeda (администратор)
2008-07-04 01:45

It's wrong to have ods_use_new_bluez_api() defined in ods-common.h and implemented in ods-main.c. header and implementation files must match. The correct way would be to have a variable and two functions (set/get) defined in ods-common.c, then from ods-main.c you would call set function and use get function everywhere else.
(0000352)
manuel (инициатор)
2008-07-06 01:22

Mhh that makes sense, updated patch.

I also added short commands versions for no-daemon and system-bus.

Does it make any sense to provide a method that allows to know the API been used from the dbus client side?
(0000357)
skirsdeda (администратор)
2008-07-10 15:24

This patch has to include actual changes to bluez.c (SDP record searching) to use 4.x API.
(0000362)
manuel (инициатор)
2008-07-13 23:39

Actually the old api is still available even though if the new one is registered. So there's no fear it will break anything, and we can do this stuff more slowly.

But we need an option in runtime to tell if we're using or not the new api so we can use this new features.

Anyway BlueZ 4.0 will not start to be really developed any time soon, so there's no rush, I don't think you should mark this really needed for 0.4
(0000394)
heston_james (инициатор)
2008-08-04 18:02

Manuel,

Just to enhance on your idea:

"But we need an option in runtime to tell if we're using or not the new api so we can use this new features."

This would be a nice idea, I would like to see another method on the manager object perhaps like GetVersion() which returns the version number for ODS which is being used, these things can sometimes come in handy for logging on our higher level apps.

Heston
(0000419)
skirsdeda (администратор)
2008-09-23 18:36

Fixed in svn rev 1950

- история
Дата изменения Пользователь Поле Изменение
2008-05-09 17:07 cktakahasi Новый вопрос
2008-05-12 15:48 heston_james Комментарий добавлен: 0000232
2008-05-12 15:50 heston_james Отслеживать: heston_james
2008-06-28 21:16 skirsdeda Состояние новый => назначен
2008-06-28 21:16 skirsdeda Ответственный => skirsdeda
2008-06-28 21:17 skirsdeda Комментарий добавлен: 0000325
2008-06-28 21:22 skirsdeda Связь добавлена блокирует 0000058
2008-06-29 12:57 heston_james Комментарий добавлен: 0000327
2008-07-02 18:17 manuel Комментарий добавлен: 0000337
2008-07-02 18:17 manuel Файл добавлен: new_api.patch
2008-07-04 01:45 skirsdeda Комментарий добавлен: 0000351
2008-07-06 01:22 manuel Комментарий добавлен: 0000352
2008-07-06 01:23 manuel Файл добавлен: ods_bluez4_api.patch
2008-07-10 15:24 skirsdeda Комментарий добавлен: 0000357
2008-07-13 23:39 manuel Комментарий добавлен: 0000362
2008-08-04 18:02 heston_james Комментарий добавлен: 0000394
2008-09-23 18:34 skirsdeda Целевая версия => 0.3.5
2008-09-23 18:36 skirsdeda Комментарий добавлен: 0000419
2008-09-23 18:36 skirsdeda Состояние назначен => отработан
2008-09-23 18:36 skirsdeda Решен в версии => 0.3.5
2008-09-23 18:36 skirsdeda Решение открыт => решен
2008-10-17 19:58 skirsdeda Целевая версия 0.3.5 => 0.4
2008-10-17 19:59 skirsdeda Решен в версии 0.3.5 => 0.4
2008-10-17 19:59 skirsdeda Состояние отработан => закрыт


Mantis 1.1.6[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker